Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Off-chain] feat: in-memory query cache(s) #994
base: main
Are you sure you want to change the base?
[Off-chain] feat: in-memory query cache(s) #994
Changes from 25 commits
830a7f6
b0f08c3
8743246
d895441
23cc94a
366ab1d
4632c74
a467428
e48a2f2
d5ce62f
71da7f1
6774d3a
086d219
d6dbc44
0414e9a
d1c024e
b221a55
e136271
43fd1d8
f2f1d78
b6cff36
0e761e5
dae1509
1900c99
4bc78a0
32475f2
5c23f3f
737f073
4e163be
404f00e
d84cf55
5a015a3
9205129
bbe7dc5
b08c668
2847a2a
8813054
906d8d9
51fc916
6e3c577
68ce4ae
50adabe
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are they pruned or just not considered cache hits? #PUC
If they're evicted, please make that explicit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the above ("pruned" == "evicted" == "deleted"). As it states, they ARE pruned. The word "evict" has only been used so far in a slightly different context, related to the
MaxKeys
config field.Do you have a specific suggestion on how to improve clarity here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.