Skip to content

[DO NOT MERGE] Chain Halt Mitigation #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Olshansk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[DO NOT MERGE] Chain Halt Mitigation #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 60 additions & 14 deletions consensus/state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ var (
ErrVoteHeightMismatch = errors.New("error vote height mismatch")
)

var chainHaltHeight = int64({UPDATE_ME_WITH_CHAIN_HALT_HEIGHT}})
var chainHaltRound = 100
var timeoutWait = time.Second * 20
var timeoutPropose = time.Second * 600

//-----------------------------------------------------------------------------

var (
Expand Down Expand Up @@ -320,6 +325,10 @@ func (cs *State) OnStart() error {

// we may have lost some votes if the process crashed
// reload from consensus log to catchup
if cs.Height == chainHaltHeight {
cs.Logger.Info(fmt.Sprintf("Skipping Wal Replay For Height %d Patch", chainHaltHeight))
cs.doWALCatchup = false
}
if cs.doWALCatchup {
if err := cs.catchupReplay(cs.Height); err != nil {
// don't try to recover from data corruption error
Expand All @@ -345,12 +354,23 @@ go run scripts/json2wal/main.go wal.json $WALFILE # rebuild the file without cor
}
}

if cs.Height == chainHaltHeight {
cs.updateRoundStep(chainHaltRound, cstypes.RoundStepNewHeight)
cs.Votes.SetRound(chainHaltRound)
}

// now start the receiveRoutine
go cs.receiveRoutine(0)

// schedule the first round!
// use GetRoundState so we don't race the receiveRoutine for access
cs.scheduleRound0(cs.GetRoundState())
if cs.Height == chainHaltHeight {
// schedule the first round!
// use GetRoundState so we don't race the receiveRoutine for access
cs.scheduleRoundCH(cs.GetRoundState())
} else {
// schedule the first round!
// use GetRoundState so we don't race the receiveRoutine for access
cs.scheduleRound0(cs.GetRoundState())
}

return nil
}
Expand Down Expand Up @@ -478,6 +498,12 @@ func (cs *State) scheduleRound0(rs *cstypes.RoundState) {
cs.scheduleTimeout(sleepDuration, rs.Height, 0, cstypes.RoundStepNewHeight)
}

// enterNewRound(height, chainHaltRound) at cs.StartTime.
func (cs *State) scheduleRoundCH(rs *cstypes.RoundState) {
cs.Logger.Info(fmt.Sprintf("Schedule Round %d", chainHaltRound))
cs.scheduleTimeout(0, rs.Height, chainHaltRound, cstypes.RoundStepNewRound)
}

// Attempt to schedule a timeout (by sending timeoutInfo on the tickChan)
func (cs *State) scheduleTimeout(duration time.Duration, height int64, round int, step cstypes.RoundStepType) {
cs.timeoutTicker.ScheduleTimeout(timeoutInfo{duration, height, round, step})
Expand Down Expand Up @@ -773,9 +799,18 @@ func (cs *State) handleTimeout(ti timeoutInfo, rs cstypes.RoundState) {
case cstypes.RoundStepNewHeight:
// NewRound event fired from enterNewRound.
// XXX: should we fire timeout here (for timeout commit)?
cs.enterNewRound(ti.Height, 0)
if rs.Height == chainHaltHeight {
cs.enterNewRound(ti.Height, rs.Round)
} else {
cs.enterNewRound(ti.Height, 0)
}
case cstypes.RoundStepNewRound:
cs.enterPropose(ti.Height, 0)
if rs.Height == chainHaltHeight {
cs.Logger.Info("Enter Round Step New Round")
cs.enterPropose(ti.Height, rs.Round)
} else {
cs.enterPropose(ti.Height, 0)
}
case cstypes.RoundStepPropose:
cs.eventBus.PublishEventTimeoutPropose(cs.RoundStateEvent())
cs.enterPrevote(ti.Height, ti.Round)
Expand Down Expand Up @@ -937,9 +972,14 @@ func (cs *State) enterPropose(height int64, round int) {
cs.enterPrevote(height, cs.Round)
}
}()

// If we don't get the proposal and all block parts quick enough, enterPrevote
cs.scheduleTimeout(cs.config.Propose(round), height, round, cstypes.RoundStepPropose)
if height == chainHaltHeight {
cs.Logger.Info(fmt.Sprintf("Wait for up to %d minutes for the proposal block", timeoutPropose))
// If we don't get the proposal and all block parts quick enough, enterPrevote
cs.scheduleTimeout(timeoutPropose, height, round, cstypes.RoundStepPropose)
} else {
// If we don't get the proposal and all block parts quick enough, enterPrevote
cs.scheduleTimeout(cs.config.Propose(round), height, round, cstypes.RoundStepPropose)
}

// Nothing more to do if we're not a validator
if cs.privValidators == nil {
Expand Down Expand Up @@ -1176,9 +1216,12 @@ func (cs *State) enterPrevoteWait(height int64, round int) {
cs.updateRoundStep(round, cstypes.RoundStepPrevoteWait)
cs.newStep()
}()

// Wait for some more prevotes; enterPrecommit
cs.scheduleTimeout(cs.config.Prevote(round), height, round, cstypes.RoundStepPrevoteWait)
if height == chainHaltHeight {
cs.scheduleTimeout(timeoutWait, height, round, cstypes.RoundStepPrevoteWait)
} else {
// Wait for some more prevotes; enterNewRound
cs.scheduleTimeout(cs.config.Prevote(round), height, round, cstypes.RoundStepPrevoteWait)
}
}

// Enter: `timeoutPrevote` after any +2/3 prevotes.
Expand Down Expand Up @@ -1311,9 +1354,12 @@ func (cs *State) enterPrecommitWait(height int64, round int) {
cs.newStep()
}()

// Wait for some more precommits; enterNewRound
cs.scheduleTimeout(cs.config.Precommit(round), height, round, cstypes.RoundStepPrecommitWait)

if height == chainHaltHeight {
cs.scheduleTimeout(timeoutWait, height, round, cstypes.RoundStepPrecommitWait)
} else {
// Wait for some more precommits; enterNewRound
cs.scheduleTimeout(cs.config.Precommit(round), height, round, cstypes.RoundStepPrecommitWait)
}
}

// Enter: +2/3 precommits for block
Expand Down