fix: Validate/coerce types for comparisons within join_where predicates #21049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
fix
nameexhaustion
changed the title
nameexhaustion
force-pushed
the
join-where-key-type-coerce
branch
from
a7df6fe to
d216e4a
Compare
nameexhaustion
force-pushed
the
join-where-key-type-coerce
branch
from
d216e4a to
3693a97
Compare
nameexhaustion
commented
Feb 5, 2025
| }, | ||
| _ => true, | ||
| }); | ||
| polars_ensure!( valid, InvalidOperation: "'join_where' predicate only refers to columns from a single table") |
There was a problem hiding this comment.
check refactored to process_join_where_predicate() below
nameexhaustion
changed the title
nameexhaustion
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21049 +/- ##
==========================================
+ Coverage 79.19% 79.27% +0.07%
==========================================
Files 1585 1585
Lines 226009 226132 +123
Branches 2592 2592
==========================================
+ Hits 178985 179257 +272
+ Misses 46429 46280 -149
Partials 595 595 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Feb 5, 2025
|
@nameexhaustion I also got this python error? Any idea what it is? |
I will make a PR to fix |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a type validation / coercion step to join_where predicates. This ensures comparison expressions within the predicates have compatible dtypes (matching, or have a lossless supertype).
Drive-by
is_comparison()function tois_comparison_or_bitwise()to better reflect what it matches