Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Fix minor histogram issues #21088

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

mcrumiller
Copy link
Contributor

Closes #21082 and closes #20879.

Minor fixes:

  1. Ensure upper breakpoint is equal to upper value when bins are auto-computed (due to floating point issues, sometimes the max value would be e.g. 7.0 and the upper bin limit would be 6.999999...).
  2. NaN values were not being skipped and sometimes fell into the default logical path which incremented a bucket.

@github-actions github-actions bot added fix Bug fix rust Related to Rust Polars labels Feb 5, 2025
@mcrumiller mcrumiller marked this pull request as ready for review February 5, 2025 02:59
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.27%. Comparing base (a578d51) to head (4ca7f87).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #21088   +/-   ##
=======================================
  Coverage   79.27%   79.27%           
=======================================
  Files        1586     1586           
  Lines      225676   225681    +5     
  Branches     2588     2588           
=======================================
+ Hits       178894   178901    +7     
+ Misses      46192    46190    -2     
  Partials      590      590           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit be317eb into pola-rs:main Feb 5, 2025
28 checks passed
@mcrumiller mcrumiller deleted the hist branch February 5, 2025 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix rust Related to Rust Polars
Projects
None yet
2 participants