feat: Support reading arrow Map type from Delta #21330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
nameexhaustion
commented
Feb 18, 2025
| DataType::BinaryOffset | ||
| } | ||
| }, | ||
| ArrowDataType::FixedSizeBinary(_) => DataType::Binary, | ||
| dt => panic!("Arrow datatype {dt:?} not supported by Polars. You probably need to activate that data-type feature."), |
There was a problem hiding this comment.
rustfmt broke because this string line was too long
nameexhaustion
commented
Feb 18, 2025
| first_schema | ||
| .iter() | ||
| .map(|(name, field)| { | ||
| (name.clone(), slf_schema.get(name).unwrap_or(field).clone()) |
There was a problem hiding this comment.
Ensures we use the Field from the metadata of this file
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21330 +/- ##
=======================================
Coverage 79.85% 79.85%
=======================================
Files 1596 1596
Lines 228642 228671 +29
Branches 2615 2615
=======================================
+ Hits 182571 182600 +29
Misses 45473 45473
Partials 598 598 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POLARS_FORCE_MULTISCANturned onThis involves adding a dispatch and fixing a bug.