Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust): Incorrect atomic ordering in Connector #21341

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Feb 19, 2025

I don't know how I made these silly mistakes, in my mind I associated "Acquire" with receiving and "Release" with sending, but in fact both sender and receiver must both acquire and send to properly synchronize.

@orlp orlp changed the title fix: Incorrect atomic ordering in Connector fix(rust): Incorrect atomic ordering in Connector Feb 19, 2025
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 19, 2025
@orlp orlp merged commit d6bb315 into pola-rs:main Feb 19, 2025
24 checks passed
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.85%. Comparing base (4e286d8) to head (6c59d44).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...es/polars-stream/src/async_primitives/connector.rs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21341      +/-   ##
==========================================
- Coverage   79.92%   79.85%   -0.08%     
==========================================
  Files        1596     1596              
  Lines      228745   228746       +1     
  Branches     2616     2616              
==========================================
- Hits       182825   182658     -167     
- Misses      45321    45489     +168     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant