Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix ColumnNotFound error selecting len() after semi/anti join #21355

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 20, 2025

Note that there are a few other occurrences of acc_projections.is_empty() - I'm not sure whether those can be problematic:

image

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.94%. Comparing base (4e286d8) to head (9bcbe7d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21355      +/-   ##
==========================================
+ Coverage   79.92%   79.94%   +0.01%     
==========================================
  Files        1596     1596              
  Lines      228745   228623     -122     
  Branches     2616     2618       +2     
==========================================
- Hits       182825   182764      -61     
+ Misses      45321    45260      -61     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Ah yes, this is due to a recent optimization that doesn't select (the first column) anymore for select(pl.len()).

@ritchie46 ritchie46 merged commit 42104e2 into pola-rs:main Feb 20, 2025
29 checks passed
@sergiojarala
Copy link

Ah yes, this is due to a recent optimization that doesn't select (the first column) anymore for select(pl.len()).

Doesn’t select (the first column) only after anti/semi joins? Or always ? I used to do select(pl.len()) to determine the number of rows in a Lazyframe thinking this would be less expensive than collecting the lazyframe and then do .height()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
3 participants