Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Panic when projecting only row index from IPC file #21361

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

lukemanley
Copy link
Contributor

fixes #21165

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.90%. Comparing base (4f88b5f) to head (b18868c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21361      +/-   ##
==========================================
- Coverage   79.91%   79.90%   -0.01%     
==========================================
  Files        1597     1597              
  Lines      228716   228718       +2     
  Branches     2618     2618              
==========================================
- Hits       182773   182765       -8     
- Misses      45344    45354      +10     
  Partials      599      599              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukemanley
Copy link
Contributor Author

@coastalwhite - any thoughts on the failure here? It seems like it could be related but I'm unable to produce the failure locally.

@coastalwhite
Copy link
Collaborator

coastalwhite commented Feb 20, 2025

I looked at it. I have no idea how this never triggered before, but there is a race condition in the tests there. On it.

@lukemanley
Copy link
Contributor Author

thanks @coastalwhite

@ritchie46 ritchie46 merged commit 1ae49b9 into pola-rs:main Feb 21, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when projecting only row index from IPC file
3 participants