fix: Invalid usage of drop_first in to_dummies when nulls present
#25435
+75
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25334.
If the series has nulls, then it's possible that the first tuple group will be the null group. We must ensure if
drop_first=Truethat we drop the first non_null group, which may be the second group. So the.skip(...)sometimes gets it wrong. This fixes the issue.I also combined some of the unit tests with parametrization for slightly better coverage.