Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] fix foreign key table meta #204

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[Hotfix] fix foreign key table meta #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion polardbx-executor/src/main/java/com/alibaba/polardbx/executor/handler/HandlerCommon.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1041,6 +1041,7 @@ protected List<List<Object>> getConditionValueList(ForeignKeyData data, TableMet
return conditionValueList;
}

// when check front, tableMeta is child table, check back, tableMeta is parent table
protected List<String> getSortedColumns(boolean isFront, TableMeta tableMeta, ForeignKeyData data) {
Map<String, String> columnMap = isFront ?
IntStream.range(0, data.columns.size()).collect(TreeMaps::caseInsensitiveMap,
Expand Down Expand Up @@ -1167,6 +1168,7 @@ protected void beforeUpdateFkCheck(TableModify tableModify, String schemaName, S

PhysicalPlanBuilder builder = new PhysicalPlanBuilder(schemaName, executionContext);

// parent table
final TableMeta parentTableMeta = executionContext.getSchemaManager(schemaName).getTableWithNull(tableName);
if (parentTableMeta == null) {
throw new TddlRuntimeException(ErrorCode.ERR_ADD_UPDATE_FK_CONSTRAINT, schemaName, tableName,
Expand Down Expand Up @@ -1386,6 +1388,7 @@ protected void beforeDeleteFkCascade(LogicalModify logicalModify, String schemaN

PhysicalPlanBuilder builder = new PhysicalPlanBuilder(schemaName, executionContext);

// child table
final TableMeta refTableMeta = executionContext.getSchemaManager(schemaName).getTable(tableName);

// get select condition values
Expand All @@ -1403,7 +1406,7 @@ protected void beforeDeleteFkCascade(LogicalModify logicalModify, String schemaN
builder, null,
false, false);

List<String> sortedColumns = getSortedColumns(false, refTableMeta, data.getValue());
List<String> sortedColumns = getSortedColumns(false, tableMeta, data.getValue());

List<List<Object>> selectValues = getSelectValues(executionContext, schemaName,
refTableMeta, conditionValueList, logicalModify, memoryAllocator, builder, shardResults,
Expand Down
Loading