Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:change java-agent configmap #189

Closed
wants to merge 6 commits into from
Closed

fix:change java-agent configmap #189

wants to merge 6 commits into from

Conversation

fredrikliu
Copy link
Contributor

@fredrikliu fredrikliu commented Jul 5, 2024 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #188

  1. Fixed the bug in the pr last time, the IP and address name of the configuration center are the same
  2. Change the agent path delivered in java-tool-option to a fixed path, and do not deliver the agent path after combining it with agentvesion
  3. Change the agentconfigmap
    To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
  • Docs
  • Inject Sidecar
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

chuntaojun
chuntaojun suggested changes Jul 5, 2024
View reviewed changes
pkg/inject/pkg/kube/inject/apply/javaagent/patch.go
}

const (
ActiveJavaAgentCmd = "-javaagent:/app/lib/.polaris/java_agent/polaris-java-agent-%s/polaris-agent-core-bootstrap.jar"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

老版本怎么兼容？

@fredrikliu fredrikliu closed this by deleting the head repository Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuntaojun chuntaojun chuntaojun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredrikliu @chuntaojun