Multi-currencies #18
Draft
Multi-currencies #18
+224
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psincraian
reviewed
Nov 10, 2025
Collaborator
psincraian
left a comment
psincraian
left a comment
There was a problem hiding this comment.
Really nice writeup François!
|
|
||
| - Store presentment amount and currency in the current amount fields. | ||
| - When receiving a payment or refund from Stripe, we'll need to get the converted amount in `usd` Stripe calculated (from the balance transaction), to impact the merchant's Account balance. | ||
| - Revamp metrics so amount are always computed in `usd`, directly from the Account transactions amount. |
Collaborator
There was a problem hiding this comment.
How will history work with exchange rates?
Member
Author
There was a problem hiding this comment.
So, the idea is to store the converted amount (say usd for simplicity) in the account transactions (at the moment we receive the payment), and use them not only for payouts like we do today, but for metrics.
Effectively, if you look at MRR, a single subscription might fluctuate over months following exchange rates.
|
|
||
| ## Technical Considerations and Open Questions | ||
|
|
||
| ### Polar fees |
|
|
||
| When issuing a refund, we'll issue it in the original presentment currency. If the exchange rate has changed since the original payment, we might have to withdwraw more money from the merchant's balance than the original payment amount (in settlement currency). | ||
|
|
||
| For example, if a customer paid 100 EUR when the exchange rate was 1 EUR = 1.1 USD, the merchant received 110 USD. If we refund the customer later when the exchange rate is 1 EUR = 1.2 USD, we need to withdraw 120 USD from the merchant's balance to refund the customer. |
Collaborator
There was a problem hiding this comment.
What will happen if the merchant doesn't have enough balance?
Member
Author
There was a problem hiding this comment.
They'll go negative. It can already happen today if we do a refund after the funds have been paid out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.