Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@pieterbeulque |
There was a problem hiding this comment.
Pull request overview
This PR adds Korean language support to the i18n package, enabling the application to serve Korean-speaking users in South Korea. The implementation follows the established pattern used by other translations in the codebase.
Changes:
- Added complete Korean translation file with all checkout, benefit, and interval strings
- Registered Korean locale in the configuration alongside existing languages
- Updated cache with English source strings for translation reference
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| clients/packages/i18n/src/locales/ko.ts | New Korean translation file with 206 lines covering all UI strings for checkout flows, benefits, intervals, and ordinals |
| clients/packages/i18n/src/config.ts | Added 'ko' to SUPPORTED_LOCALES array and "Korean (South Korea)" to LOCALE_NAMES |
| clients/packages/i18n/src/locales/config/.cache.json | Added English source string cache entries for the Korean locale |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@bytaesu would you mind taking a second look at the translations? It's hard for us (Polar team) to verify these translations since it's far from our comfort zone 😁 |
pieterbeulque
force-pushed
the
pieter/add-korean
branch
from
00b105e to
2ef27c0
Compare
Sure!! I'll check today 😄 |
| export default { | ||
| checkout: { | ||
| footer: { | ||
| poweredBy: '제공:', |
There was a problem hiding this comment.
It sounds natural, and in fact, many Korean services use “Powered by” as-is without translating it.
| province: '도', | ||
| stateProvince: '주 / 도', | ||
| }, | ||
| taxId: '납세자 번호', |
There was a problem hiding this comment.
If this field is intended for businesses, "납세자 번호" -> “사업자등록번호” would be more natural.
+) "사업자등록번호" means "Business Registration Number (BRN)"
| billingAddress: { | ||
| label: '청구지 주소', | ||
| line1: '주소', | ||
| line2: '상세 주소', | ||
| postalCode: '우편번호', | ||
| city: '도시', | ||
| country: '국가', | ||
| state: '주', | ||
| province: '도', | ||
| stateProvince: '주 / 도', | ||
| }, |
There was a problem hiding this comment.
| billingAddress: { | |
| label: '청구지 주소', | |
| line1: '주소', | |
| line2: '상세 주소', | |
| postalCode: '우편번호', | |
| city: '도시', | |
| country: '국가', | |
| state: '주', | |
| province: '도', | |
| stateProvince: '주 / 도', | |
| }, | |
| billingAddress: { | |
| label: '청구지 주소', | |
| line1: '주소', | |
| line2: '상세 주소', | |
| postalCode: '우편번호', | |
| city: '시/군/구', | |
| country: '국가', | |
| state: '시/도', | |
| province: '시/도', | |
| stateProvince: '시/도', | |
| }, |
Korea doesn't have a state or province concept. I'm not sure how this is reflected in the UI, but this seems the most natural option.
No description provided.