Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optimization phases, update package.yaml-s #382

Merged
merged 2 commits into from
Oct 23, 2020

Conversation

TheMatten
Copy link
Collaborator

Fixes polysemy-research/polysemy-zoo#65 by removing optimization phases, which weren't really used up until now and don't solve the original problem anyway. Additionally I've fixed warnings in package.yaml files and fixed bound on th-abstraction being modified only in polysemy.cabal.

@googleson78
Copy link
Member

travis not passing, but of course it doesn't show up in the PR for some reason :)
https://travis-ci.org/github/polysemy-research/polysemy/builds/738241715

@TheMatten
Copy link
Collaborator Author

travis not passing, but of course it doesn't show up in the PR for some reason :)
https://travis-ci.org/github/polysemy-research/polysemy/builds/738241715

Warning: Packages using 'cabal-version: 2.0' and the autogenerated module
Paths_* must include it also on the 'autogen-modules' field besides
'exposed-modules' and 'other-modules'. This specifies that the module does not
come with the package and is generated on setup. Modules built with a custom
Setup.hs script also go here to ensure that commands like sdist don't fail.

So I guess I should just add them to generated-other-modules too? 😄

@TheMatten
Copy link
Collaborator Author

CI is green now 🎉

@googleson78 googleson78 merged commit 3399de1 into master Oct 23, 2020
@isovector isovector deleted the remove-extra-phases branch October 19, 2021 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghc 8.10 and ghc-prim bound
2 participants