Refactored MMR to Use Iteractors instead of Arrays #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm looks like we might not use the same OS so the commit diff shows that the whole file has been changed, thats gonna be annoying :/ |
seunlanlege
reviewed
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored MMR to Use Iteractors instead of Arrays, I updated the current test suite to be compatible but havent added more tests so coverage will be lower.
I added a struct LeafIterator for ease of use but it might look ugly in the tests since we end up calling it with MerkleMountainRange.LeafIterator, but again they are just tests so i guess its fine.