Test not pomm property extractor #101
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanpii
reviewed
Jun 12, 2018
tests/composer.json
Outdated
| "pomm-project/pomm-bundle": "dev-master", | ||
| "pomm-project/pomm-symfony-bridge": "~2.5" | ||
| "pomm-project/pomm-symfony-bridge": "~2.5", | ||
| "phpdocumentor/reflection": "^3.0" |
rdavaillaud
force-pushed
the
test-non-pomm-property-extractor_2
branch
from
4edcdfa to
d29d067
Compare
sanpii
requested changes
Jul 4, 2018
tests/src/AppBundle/Book.php
Outdated
| * @param string $title | ||
| */ | ||
| public function setTitle($title) | ||
| public function setTitle(string $title) |
Contributor
Author
There was a problem hiding this comment.
yeah I know, it's just my path to resolve all of this ;) things will become green soon.
This avoid collision with initial extractors
rdavaillaud
force-pushed
the
test-non-pomm-property-extractor_2
branch
3 times, most recently
from
41c267f to
e4e65ea
Compare
added 2 commits
July 4, 2018 17:05
In order to use the PhpDoc Extractor, we need phpdocumentor/reflection. We need different version with different php version.
rdavaillaud
force-pushed
the
test-non-pomm-property-extractor_2
branch
from
cbbfeed to
4509faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for the property extractor.
Yes, they miserably failed, on purpose.
See pomm-project/pomm-symfony-bridge#39 to view the correction