Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change HTTPClient handler factory creation #106

Merged
merged 7 commits into from
Jan 21, 2024

Conversation

sacovo
Copy link
Contributor

@sacovo sacovo commented Jan 21, 2024

The handler factory was supplied in the apply method of a client together with the Payload for the request. If the client already had a session for the new host, port and scheme, no new session was created and the supplied handler factory wasn't used.

The new design makes it clear, that one client uses the same handler factory for all requests it makes. If different handler factories are needed, different clients need to be created.

The handler factory was supplied in the apply method of a client
together with the Payload for the request. If the client
already had a session for the new host, port and scheme, no new
session was created and the supplied handler factory wasn't used.

The new design makes it clear, that one client uses the same handler
factory for all requests it makes. If different handler factories are
needed, different clients need to be created.
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Jan 21, 2024
@SeanTAllen SeanTAllen changed the title Change handler factory creation of HTTPClient (issue #102) Change HTTPClient handler factory creation Jan 21, 2024
@SeanTAllen SeanTAllen added the changelog - changed Automatically add "Changed" CHANGELOG entry on merge label Jan 21, 2024
@ponylang-main
Copy link
Contributor

Hi @sacovo,

The changelog - changed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 106.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

@sacovo thank you. as part of your release notes, please include a "how to upgrade" portion that shows what example old version code would look like and what the new version looks like.

@SeanTAllen SeanTAllen requested a review from a team January 21, 2024 13:57
The handler factory was supplied in the apply method of a client
together with the Payload for the request. If the client
already had a session for the new host, port and scheme, no new
session was created and the supplied handler factory wasn't used.

The new design makes it clear, that one client uses the same handler
factory for all requests it makes. If different handler factories are
needed, different clients need to be created.

Closes ponylang#102
Closes ponylang#9
@SeanTAllen SeanTAllen added the do not merge This PR should not be merged at this time label Jan 21, 2024
.release-notes/106.md Outdated Show resolved Hide resolved
.release-notes/106.md Outdated Show resolved Hide resolved
.release-notes/106.md Outdated Show resolved Hide resolved
.release-notes/106.md Outdated Show resolved Hide resolved
@SeanTAllen SeanTAllen merged commit 1e9b608 into ponylang:main Jan 21, 2024
8 checks passed
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Jan 21, 2024
github-actions bot pushed a commit that referenced this pull request Jan 21, 2024
github-actions bot pushed a commit that referenced this pull request Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - changed Automatically add "Changed" CHANGELOG entry on merge do not merge This PR should not be merged at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants