Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change HTTPClient handler factory creation #106

Merged
merged 7 commits into from
Jan 21, 2024
Merged

Change HTTPClient handler factory creation #106

merged 7 commits into from
Jan 21, 2024

Commits on Jan 21, 2024

  1. Change handler factory creation of HTTPClient (issue ponylang#102) 

    The handler factory was supplied in the apply method of a client
together with the Payload for the request. If the client
already had a session for the new host, port and scheme, no new
session was created and the supplied handler factory wasn't used.

The new design makes it clear, that one client uses the same handler
factory for all requests it makes. If different handler factories are
needed, different clients need to be created.
    @sacovo
    sacovo committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    18653a3 View commit details
    Browse the repository at this point in the history

  2. Change handler factory creation of HTTPClient (issue ponylang#102) 

    The handler factory was supplied in the apply method of a client
together with the Payload for the request. If the client
already had a session for the new host, port and scheme, no new
session was created and the supplied handler factory wasn't used.

The new design makes it clear, that one client uses the same handler
factory for all requests it makes. If different handler factories are
needed, different clients need to be created.

Closes ponylang#102
Closes ponylang#9
    @sacovo
    sacovo committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    df5f80e View commit details
    Browse the repository at this point in the history

  3. Add release note for pull request ponylang#106

    @sacovo
    sacovo committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    6c603f4 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'sac-client-handler' of github.com:sacovo/http into sac-… 

    …client-handler
    @sacovo
    sacovo committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    df4306a View commit details
    Browse the repository at this point in the history

  5. Fix typos and formating in release note

    @sacovo
    sacovo committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    0dc9260 View commit details
    Browse the repository at this point in the history

  6. Update .release-notes/106.md

    @SeanTAllen
    SeanTAllen authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    7dedd6e View commit details
    Browse the repository at this point in the history

  7. Update .release-notes/106.md

    @SeanTAllen
    SeanTAllen authored Jan 21, 2024
    Configuration menu
    Copy the full SHA
    b3d798b View commit details
    Browse the repository at this point in the history