Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtrace support is missing from the Makefile #4449

Closed
SeanTAllen opened this issue Sep 17, 2023 · 3 comments · Fixed by #4453
Closed

dtrace support is missing from the Makefile #4449

SeanTAllen opened this issue Sep 17, 2023 · 3 comments · Fixed by #4453
Assignees
@chalcolith
Labels
bug Something isn't working

Comments

@SeanTAllen
Copy link
Member

SeanTAllen commented Sep 17, 2023 •
edited
Loading

We have a "use" for dtrace but the actual working support is missing. Probably got lost when we moved to CMake.

You can see the original support here:

59ca6bc

Which is probably what we want.

When someone fixes this, we should add a CI job to verify it is working going forward.

The package to install for ubuntu to get the dtrace command installed is systemtap-sdt-dev.

We also should add information on building with dtrace to BUILD.md.
@SeanTAllen SeanTAllen added bug Something isn't working needs investigation This needs to be looked into before its "ready for work" labels Sep 17, 2023
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Sep 17, 2023
@SeanTAllen
Copy link
Member Author

@chalcolith do you feel comfortable adding this back in?

@SeanTAllen SeanTAllen added good first issue Good for newcomers and removed good first issue Good for newcomers labels Sep 17, 2023
@SeanTAllen
Copy link
Member Author

@chalcolith the "ar" "ofiles" code from our pre-cmake days was linking the dtrace_probes.o into libponyrt.

@SeanTAllen
Copy link
Member Author

@chalcolith when you finish this, open a draft PR and Ill update it with CI to verify we can build with dtrace.

@SeanTAllen SeanTAllen removed needs investigation This needs to be looked into before its "ready for work" discuss during sync Should be discussed during an upcoming sync labels Sep 19, 2023
@chalcolith chalcolith mentioned this issue Sep 24, 2023
Merged
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
e7acf5f 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
64956ba 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
c408fb3 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
29d47f4 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
639c109 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
d77739a 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
d825cfd 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
SeanTAllen pushed a commit that referenced this issue Sep 24, 2023
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
617972a 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
chalcolith added a commit that referenced this issue Sep 26, 2023
@chalcolith
Generate and link dtrace probes for libponyrt (#4453)
d13e39a 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option is used.

Fixes #4449
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalcolith chalcolith

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix broken DTrace support ponylang/ponyc
3 participants
@chalcolith @SeanTAllen @ponylang-main