Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken DTrace support #4453

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix broken DTrace support #4453

merged 1 commit into from
Sep 26, 2023

Conversation

chalcolith
Copy link
Member

@chalcolith chalcolith commented Sep 24, 2023 •
edited by SeanTAllen
Loading

Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into libponyrt if the
use=dtrace option.

Fixes #4449

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Sep 24, 2023
@chalcolith
Copy link
Member Author

@SeanTAllen dtrace_probes.o will now be generated and linked if you do make configure use=dtrace.

@SeanTAllen SeanTAllen force-pushed the fix_4449 branch 3 times, most recently from 64956ba to c408fb3 Compare September 24, 2023 18:45
@SeanTAllen SeanTAllen marked this pull request as ready for review September 24, 2023 18:46
@SeanTAllen SeanTAllen force-pushed the fix_4449 branch 3 times, most recently from 639c109 to d77739a Compare September 24, 2023 19:03
@SeanTAllen SeanTAllen changed the title Generate and link dtrace probes for libponyrt Fix broken DTrace support Sep 24, 2023
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Sep 24, 2023
@SeanTAllen SeanTAllen requested a review from a team September 24, 2023 19:06
@chalcolith @SeanTAllen
Generate and link dtrace probes for libponyrt
617972a 
Dtrace functionality was missed when converting the build system to cmake.
This PR generates and links dtrace probes into `libponyrt` if the
`use=dtrace` option.

Fixes #4449
@chalcolith chalcolith merged commit d13e39a into main Sep 26, 2023
21 checks passed
@chalcolith chalcolith deleted the fix_4449 branch September 26, 2023 18:06
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Sep 26, 2023
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@ponylang-main
Update CHANGELOG for PR #4453
46e7b43
github-actions bot pushed a commit that referenced this pull request Sep 26, 2023
@ponylang-main
Updates release notes for PR #4453
57f7f1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees

@SeanTAllen SeanTAllen

Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dtrace support is missing from the Makefile
4 participants
@chalcolith @jemc @SeanTAllen @ponylang-main