Only include ponyc.exe in the bin directory of Windows release zip files
#4474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p files Previously the tests and benchmark executables were included, which doubled the size of the zip file. This PR removes those files before zipping the release archive. We do it this way because the Powershell command `Compress-Archive` cannot add a single file to a directory other than the root directory of the zip file, so we can't specify just `bin\ponyc.exe` in the list of things to add to the archive; it'll add it to the root directory. Ponyc expects to find its lib and packages directories one directory below where it is. Fixes #4272
ponylang-main
added
the
discuss during sync
SeanTAllen
approved these changes
Dec 9, 2023
ponylang-main
removed
the
discuss during sync
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests and benchmark executables were included, which doubled the size of the zip file. This PR removes those files before zipping the release archive.
We do it this way because the Powershell command
Compress-Archivecannot add a single file to a directory other than the root directory of the zip file, so we can't specify justbin\ponyc.exein the list of things to add to the archive; it'll add it to the root directory. Ponyc expects to find its lib and packages directories one directory below where it is.Fixes #4272