-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update libcosmic
#1201
Update libcosmic
#1201
Conversation
While everything seems to work visually, I seem to have very high CPU usage with this when an XWayland client is placed in a stack (causing lagginess and choppy cursor movement). |
That's an existing issue not changed by this PR, right? There aren't too many changes to Iced or Libcosmic here, and none should have an impact like that. Though that is something to look into regardless. |
The level of CPU usage and choppiness isn't present without this PR, which is why I added the comment here. Not sure why, maybe |
Odd. And that's with a release build?
|
Yes, and I'm not seeing this on the |
Sounds like most likely we are re-rendering the SSD too often again after the update, which is usually bad news, because of the text shaping (which is already a performance problem). |
7ba207d
to
77fbeee
Compare
I can reproduce this. It seems the issue isn't iced, libcosmic, or cosmic-protocols, but actually cosmic-freedesktop-icons. Downgraded back to the previous version with |
Fixes #1071.
77fbeee
to
89be4bf
Compare
Yep, there aren't any perceptible regressions now. |
Rebased, since #1206 also updated |
Fixes #1071.