Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcosmic #1201

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Update libcosmic #1201

merged 1 commit into from
Feb 8, 2025

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Feb 4, 2025

Fixes #1071.

@ids1024 ids1024 requested a review from a team February 4, 2025 19:14
@git-f0x
Copy link
Contributor

git-f0x commented Feb 4, 2025

While everything seems to work visually, I seem to have very high CPU usage with this when an XWayland client is placed in a stack (causing lagginess and choppy cursor movement).
Moving the cursor while any window is in a stack also causes high CPU usage by comp. The former might be related to the latter.

@ids1024
Copy link
Member Author

ids1024 commented Feb 4, 2025

That's an existing issue not changed by this PR, right? There aren't too many changes to Iced or Libcosmic here, and none should have an impact like that.

Though that is something to look into regardless.

@git-f0x
Copy link
Contributor

git-f0x commented Feb 4, 2025

The level of CPU usage and choppiness isn't present without this PR, which is why I added the comment here. Not sure why, maybe cctk?

@ids1024
Copy link
Member Author

ids1024 commented Feb 4, 2025

Odd. And that's with a release build?

cctk shouldn't really impact performance like that, and moreover isn't even used in cosmic-comp, since it's for Wayland clients.

@git-f0x
Copy link
Contributor

git-f0x commented Feb 4, 2025

Yes, and I'm not seeing this on the fix-maximize_noble branch.

@Drakulix
Copy link
Member

Drakulix commented Feb 5, 2025

Sounds like most likely we are re-rendering the SSD too often again after the update, which is usually bad news, because of the text shaping (which is already a performance problem).

@ids1024 ids1024 force-pushed the update-libcosmic_noble branch from 7ba207d to 77fbeee Compare February 7, 2025 22:47
@ids1024
Copy link
Member Author

ids1024 commented Feb 7, 2025

I can reproduce this. IcedElementInternal::update is taking a lot longer than it should.

It seems the issue isn't iced, libcosmic, or cosmic-protocols, but actually cosmic-freedesktop-icons. Downgraded back to the previous version with cargo update cosmic-freedesktop-icons --precise bfc22d531596b57646dc47bcd70b2eb6f3152cd4 for now. So this shouldn't regress anything any more.

@ids1024 ids1024 force-pushed the update-libcosmic_noble branch from 77fbeee to 89be4bf Compare February 7, 2025 23:00
@git-f0x
Copy link
Contributor

git-f0x commented Feb 7, 2025

Yep, there aren't any perceptible regressions now.

@ids1024
Copy link
Member Author

ids1024 commented Feb 7, 2025

Rebased, since #1206 also updated Cargo.lock.

@Drakulix Drakulix merged commit ec1026d into master Feb 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-click on server-side decorations causes window to enter drag mode
4 participants