Allow using Performance power profile on desktop #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
previously approved these changes
Mar 16, 2024
|
That should fix the failing |
|
There's no need. I will squish and rewrite the commit description on merge. |
leviport
approved these changes
Mar 18, 2024
|
Hi, do you need anything else from me on this? It says pull requests need at least 2 approving reviews before merge, but the only change since @mmstick 's approval was Thanks for your reviews. |
mmstick
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #424
This patch assumes 27192d2 specifically intended to disable Battery power profile on desktops, since desktop computers don't have battery power like laptops. I don't know what the power profiles do internally, so please let me know if that assumption is incorrect.
Also ran
rustfmton the changed area of that file, hoping to keep code style consistent with existing code.