Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonw15-b: TBT quirks, KBLED handling #436

Merged
merged 5 commits into from
Aug 15, 2024
Merged

bonw15-b: TBT quirks, KBLED handling #436

merged 5 commits into from
Aug 15, 2024

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Aug 13, 2024 •
edited by crawfxrd
Loading

  • Keep Thunderbolt controller active to work around display HPD issue
  • Disable runtime power management for TBT xHCI
  • Add handling for keyboard LED controls when using system76-dkms
  • Check for color_left if color does not exist

@jackpot51 jackpot51 requested review from jacobktm and crawfxrd August 13, 2024 20:54
@jackpot51 jackpot51 self-assigned this Aug 13, 2024
@crawfxrd
Copy link
Member

Will adding KBLED handling for system76-dkms break anything else? How do systems with proprietary firmware currently handling KBLED controls?

jackpot51 and others added 5 commits August 15, 2024 08:28
@jackpot51 @crawfxrd
Wakeup thunderbolt controller on hotplug for bonw15-b
11db49f
@crawfxrd
bonw15-b: Disable runtime pm on TBT XHCI
650dc71 
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
Keep TBT active on bonw15-b
320940f 
Under normal operation, the control channel will be stopped after a
short time of no activity:

    thunderbolt 0000:05:00.0: control channel stopped

However, hot-plug detection of displays in USB-C ports do not work if
the device is not in D0; The USD HPD itself does not wake the TBT
controller.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
hid_backlight: Try system76-dkms path
91b577f 
Attempt to use the path generated by system76-dkms if the one from
system76-acpi is not present.

Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd
hid_backlight: Check color_left if color doesn't exist
e4a3cb1 
Signed-off-by: Tim Crawford <tcrawford@system76.com>
@crawfxrd crawfxrd changed the title Wakeup thunderbolt controller on hotplug for bonw15-b bonw15-b: TBT quirks, KBLED handling Aug 15, 2024
@crawfxrd
Copy link
Member

Does the color correction for bonw15 need to be applied to bonw15-b as well?

@jackpot51
Copy link
Member Author

Does the color correction for bonw15 need to be applied to bonw15-b as well?

Yes

@crawfxrd
Copy link
Member

Colors look fine to me, and the bonw15 color correction causes white to look like light pink. Issue potentially fixed from bonw15? Probably just handled in firmware.

jacobktm
jacobktm approved these changes Aug 15, 2024
View reviewed changes
Copy link

@jacobktm jacobktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard backlight hotkeys on bonw15-b are all working as expected now!

@jackpot51 jackpot51 merged commit 03a9495 into master Aug 15, 2024
8 checks passed
@jackpot51 jackpot51 deleted the bonw15-b_jammy branch August 15, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crawfxrd crawfxrd crawfxrd approved these changes

@jacobktm jacobktm jacobktm approved these changes

Assignees

@jackpot51 jackpot51

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpot51 @crawfxrd @jacobktm