Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the path error on windows #60

Closed
wants to merge 1 commit into from
Closed

Conversation

w1zd
Copy link

@w1zd w1zd commented Jun 8, 2021

  1. windows doesnt have /dev/null, use NUL instead.
  2. root dir in windows looks like D: C:, add related logic to function resolveConfig

#44

1. windows doesnt have /dev/null, use NUL instead.
2. root dir in windows looks like D: C:, add related logic to resolveConfig
@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #60 (b55b4d9) into master (b2ef85c) will decrease coverage by 0.34%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
- Coverage   98.86%   98.51%   -0.35%     
==========================================
  Files          13       13              
  Lines         351      405      +54     
  Branches        0       57      +57     
==========================================
+ Hits          347      399      +52     
- Misses          4        6       +2     
Impacted Files Coverage Δ
lib/base_command.js 98.49% <80.00%> (-0.62%) ⬇️
lib/cache.js 97.72% <0.00%> (-2.28%) ⬇️
lib/program.js 100.00% <0.00%> (ø)
lib/command/run.js 100.00% <0.00%> (ø)
lib/command/find.js 100.00% <0.00%> (ø)
lib/command/init.js 100.00% <0.00%> (ø)
lib/command/sync.js 100.00% <0.00%> (ø)
lib/command/remove.js 100.00% <0.00%> (ø)
lib/command/runall.js 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2ef85c...b55b4d9. Read the comment docs.

@w1zd w1zd closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant