Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:部門の一括登録をできるようにした #112

Merged
merged 25 commits into from
Aug 7, 2024
Merged

feat:部門の一括登録をできるようにした #112

merged 25 commits into from
Aug 7, 2024

Conversation

Suzune2741
Copy link
Member

@Suzune2741 Suzune2741 commented Jul 18, 2024 •
edited
Loading

close #51
/entry/bulkに一括登録できるページを作成した.
READMEに利用者向け情報としてCSVファイルのフォーマット例等を書いた

CSVフォーマットが前のままなので必要なデータを教えてくれればそれに合わせて変更します

@Suzune2741 Suzune2741 self-assigned this Jul 18, 2024
@Suzune2741 Suzune2741 changed the title feat/部門の一括登録をできるようにした [WIP]feat/部門の一括登録をできるようにした Jul 18, 2024
@Suzune2741 Suzune2741 changed the title [WIP]feat/部門の一括登録をできるようにした [WIP]feat:部門の一括登録をできるようにした Jul 18, 2024
@Suzune2741 Suzune2741 marked this pull request as draft July 18, 2024 08:22
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2024 •
edited
Loading

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 224f797
Status: ✅  Deploy successful!
Preview URL: https://3f480521.kcmsx.pages.dev
Branch Preview URL: https://feat-51-bulk-registration.kcmsx.pages.dev

View logs

@Suzune2741 Suzune2741 marked this pull request as ready for review July 26, 2024 11:23
kiharu3112
kiharu3112 requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@kiharu3112 kiharu3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか気になった点があったので、対応お願いします。

packages/kcmsf/src/routes/router.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
@kiharu3112
Copy link
Contributor

それと、ロジック部分に関しては、テストをお願いします。

@kiharu3112
Copy link
Contributor

kiharu3112 commented Jul 30, 2024 •
edited
Loading

必須ではないですが、READMEにcsvの形式と例が書いてあれば嬉しいです。

tufusa
tufusa reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@tufusa tufusa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつかコメントしました。

[全体]

  • mainからのマージとコンフリクト解決をお願いします。
  • configパッケージが使えるようになると思うので、それを使ってバリデーションしてほしいです。

packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/bulkEntry.tsx Outdated Show resolved Hide resolved
@tufusa
Copy link
Contributor

tufusa commented Jul 30, 2024

この部分がインタラクティブな要素に見えづらいので、枠線を少し細くする + ドロップシャドウをつける+ 角を丸くする をやってみてほしいです。
image

@Suzune2741 Suzune2741 changed the title [WIP]feat:部門の一括登録をできるようにした feat:部門の一括登録をできるようにした Aug 5, 2024
tufusa
tufusa reviewed Aug 6, 2024
View reviewed changes
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いい感じです！いくつかコメントしました。

packages/kcmsf/src/pages/entryBulk.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/entryBulk.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/entryBulk.tsx Outdated Show resolved Hide resolved
packages/kcmsf/src/pages/entryBulk.tsx Outdated Show resolved Hide resolved
@Suzune2741 Suzune2741 requested a review from tufusa August 7, 2024 03:34
@Suzune2741 Suzune2741 enabled auto-merge (squash) August 7, 2024 03:34
tufusa
tufusa approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kiharu3112
kiharu3112 approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@kiharu3112 kiharu3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サンプルあるの良い！
LGTM!

@Suzune2741 Suzune2741 merged commit 17dc229 into main Aug 7, 2024
4 checks passed
@Suzune2741 Suzune2741 deleted the feat/51-bulk-registration branch August 7, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiharu3112 kiharu3112 kiharu3112 approved these changes

@tufusa tufusa tufusa approved these changes

@laminne laminne Awaiting requested review from laminne

Assignees

@Suzune2741 Suzune2741

Labels
None yet
Projects
kcmsx
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: エントリーを一括登録できるようにする
3 participants
@Suzune2741 @kiharu3112 @tufusa