Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: nested routerをbrowser routerに置き換えた #113

Merged
merged 5 commits into from
Jul 19, 2024

Conversation

toranomonn
Copy link
Contributor

close #104
nested routerをbrowser routerに置き換えた

Copy link

cloudflare-workers-and-pages bot commented Jul 18, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: db9fe1c
Status: ✅  Deploy successful!
Preview URL: https://13bb5e17.kcmsx.pages.dev
Branch Preview URL: https://chore-104-router.kcmsx.pages.dev

View logs

Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いい感じです。

  • 前のコードにあるbasenameの設定が消えてしまっているので、戻しておいてください。
  • コンフリクトの解決をお願いします。

@toranomonn toranomonn requested a review from tufusa July 19, 2024 06:17
@tufusa tufusa enabled auto-merge (squash) July 19, 2024 06:19
Copy link
Contributor

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tufusa tufusa merged commit 5f59d97 into main Jul 19, 2024
3 checks passed
@tufusa tufusa deleted the chore/104-router branch July 19, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

chore: ルーターのnested routerをbrowser routerに置き換える
2 participants