Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 予選対戦表の生成ができるように #288

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Sep 8, 2024

close #178
close #16

概要

追加情報:

  • 後から生成された部門で、コース番号が以前に生成された部門のコース番号と重複する(≒ 試合番号が重複する)状態になっています
    • これについては別PRで修正する必要がありそうです
  • テストが決めうちでconfigが変更されると落ちるようになっています
    • ある程度動的に動作するようにしないといけなさそうです

@laminne laminne added the backend Related to kcmsx/kcms label Sep 8, 2024
@laminne laminne self-assigned this Sep 8, 2024
@laminne laminne marked this pull request as ready for review September 8, 2024 14:48
@laminne laminne enabled auto-merge (squash) September 8, 2024 14:48
Copy link

cloudflare-workers-and-pages bot commented Sep 10, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2a7fd1c
Status: ✅  Deploy successful!
Preview URL: https://b02ba7d2.kcmsx.pages.dev
Branch Preview URL: https://feat-178-generate-pre-match.kcmsx.pages.dev

View logs

Copy link
Contributor

@kiharu3112 kiharu3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laminne laminne merged commit f16b805 into main Oct 1, 2024
4 checks passed
@laminne laminne deleted the feat/178-generate-pre-match branch October 1, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to kcmsx/kcms
Projects
Status: ✅ Done
2 participants