Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 不要なメンバ変数を除去 #375

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Oct 2, 2024

やったこと

close #371

  • Teamからいくつか不要なメンバ変数+getterを削除
    • isMultiWalk
    • category
  • Teamに足りていないメンバ変数+getterメソッドを追加
    • robotType

ToDo:

teamのAPIは一回削除しました(controllerが新しいAPIに完全に準拠していないので修正が必要そうなため、Issueは別途立てる)

@laminne laminne added backend Related to kcmsx/kcms 改善 labels Oct 2, 2024
@laminne laminne self-assigned this Oct 2, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 2, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71d3a6b
Status: ✅  Deploy successful!
Preview URL: https://1c735c4b.kcmsx.pages.dev
Branch Preview URL: https://feat-371-model-deprecated-me.kcmsx.pages.dev

View logs

@laminne laminne enabled auto-merge (squash) October 2, 2024 10:36
@laminne laminne merged commit a1a3fc5 into main Oct 2, 2024
4 checks passed
@laminne laminne deleted the feat/371-model-deprecated-member branch October 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to kcmsx/kcms 改善
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat!: モデルの非推奨メンバーをすべて消す
2 participants