Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 試合走行結果取得の実装 #390

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Conversation

Suzune2741
Copy link
Member

close #326
mainMatchのテストデータを書いた
試合走行結果取得の実装とテストを書いた

@Suzune2741 Suzune2741 self-assigned this Oct 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 4, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2d66b4c
Status: ✅  Deploy successful!
Preview URL: https://4629bbc4.kcmsx.pages.dev
Branch Preview URL: https://feat-326-fetch-run-result.kcmsx.pages.dev

View logs

Copy link
Member

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです!いくつかコメントしました。

packages/kcms/src/match/service/fetchRunResult.ts Outdated Show resolved Hide resolved
packages/kcms/src/testData/match.ts Outdated Show resolved Hide resolved
packages/kcms/src/testData/match.ts Outdated Show resolved Hide resolved
@Suzune2741 Suzune2741 enabled auto-merge (squash) October 4, 2024 09:24
@Suzune2741 Suzune2741 requested a review from tufusa October 4, 2024 09:37
@Suzune2741 Suzune2741 merged commit a13b048 into main Oct 4, 2024
4 checks passed
@Suzune2741 Suzune2741 deleted the feat/326-fetch-run-result branch October 4, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: FetchRunResultService.fetch() (試合走行結果取得)の実装
2 participants