Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: モノレポの整備 #42

Merged
merged 9 commits into from
Jul 4, 2024
Merged

feat: モノレポの整備 #42

merged 9 commits into from
Jul 4, 2024
+904 −487

Conversation

laminne
Copy link
Member

@laminne laminne commented Jul 3, 2024 •
edited
Loading

close #41

内容

  • モノレポの整備
  • CIを統合
  • pnpm workspaceによるパッケージの一元管理

@laminne laminne added frontend Related to kcmsx/kcmsf backend Related to kcmsx/kcms labels Jul 3, 2024
@laminne laminne added this to the KCMSX milestone Jul 3, 2024
@laminne laminne self-assigned this Jul 3, 2024
@laminne laminne requested review from kiharu3112 and tufusa July 3, 2024 14:29
tufusa
tufusa reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそうです！

[ask]

  • renovateの設定ファイルをルートに持ってくる必要はないですか？
  • 元のworkflowファイルが残っているのは意図通りですか？

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@laminne
Copy link
Member Author

laminne commented Jul 4, 2024 •
edited
Loading

renovateの設定ファイルをルートに持ってくる必要はないですか？

多分あるけど、設定がわからないので後回しになってます(調査中)

元のworkflowファイルが残っているのは意図通りですか？

意図的.
後に新しく書いたワークフローで良いということがわかれば消します

@tufusa
Copy link
Member

tufusa commented Jul 4, 2024

多分あるけど、設定がわからないので後回しになってます(調査中)

いまいち情報が少ないので、とりあえずrenovateを入れてみて挙動を見るのはどうでしょうか

@laminne
Copy link
Member Author

laminne commented Jul 4, 2024

どちらも同じ設定内容だったので集約しました

@laminne laminne merged commit f580a7b into main Jul 4, 2024
2 checks passed
@tufusa tufusa deleted the feat/41-setup-monorepo branch July 15, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tufusa tufusa tufusa approved these changes

@kiharu3112 kiharu3112 Awaiting requested review from kiharu3112

Assignees

@laminne laminne

Labels
backend Related to kcmsx/kcms frontend Related to kcmsx/kcmsf
Projects
kcmsx
Status: ✅ Done
Milestone
KCMSX for Matz葉がにロボコン
Development

Successfully merging this pull request may close these issues.

feat: モノレポの設定をする
2 participants
@laminne @tufusa