Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configをどじょうすくいロボコンへ対応させた #454

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

laminne
Copy link
Member

@laminne laminne commented Oct 10, 2024

close #453

やったこと

  • configをどじょうすくいロボコンに対応させた
  • テストの修正

@laminne laminne added backend Related to kcmsx/kcms config Related to kcmsx/config labels Oct 10, 2024
@laminne laminne self-assigned this Oct 10, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2024

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a446a8
Status: ✅  Deploy successful!
Preview URL: https://007d13a6.kcmsx.pages.dev
Branch Preview URL: https://feat-453-config-for-yasugi.kcmsx.pages.dev

View logs

@laminne laminne enabled auto-merge (squash) October 10, 2024 02:52
Copy link
Member

@tufusa tufusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 先フィニッシュに1点が必要です。

packages/config/src/config.ts Show resolved Hide resolved
packages/config/src/config.ts Show resolved Hide resolved
packages/config/src/config.ts Show resolved Hide resolved
packages/config/src/config.ts Outdated Show resolved Hide resolved
@tufusa
Copy link
Member

tufusa commented Oct 10, 2024

先フィニッシュについての考慮はどうしますか?一旦このPRではスルーすることにしますか?

@laminne
Copy link
Member Author

laminne commented Oct 10, 2024

先フィニッシュについての考慮はどうしますか?一旦このPRではスルーすることにしますか?

安来の方に問い合わせる必要があるので保留にした方が良さそう

@laminne laminne merged commit 77fb428 into main Oct 10, 2024
4 checks passed
@laminne laminne deleted the feat/453-config-for-yasugi branch October 10, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to kcmsx/kcms config Related to kcmsx/config
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

feat: どじょうすくいロボコンへの対応(configの書き換え)
2 participants