Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (安来用)本戦試合のランキングを取得できる #579

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat: (安来用)本戦試合のランキングを取得できる #579

merged 5 commits into from
Oct 24, 2024

Conversation

tufusa
Copy link
Member

@tufusa tufusa commented Oct 24, 2024

close #555

  • 1試合しかない(=2チームしかない)ことを前提に予選とアルゴリズムを共通化
  • (TODO) 本大会に向け、将来的にはトーナメント用アルゴリズムに書き換える必要がある
  • fix: MainMatchに走行結果を追加できない #571 のため現在実際の動作は確認できない

@tufusa tufusa self-assigned this Oct 24, 2024
@tufusa tufusa added 新機能 New feature or request backend Related to kcmsx/kcms labels Oct 24, 2024
@tufusa tufusa enabled auto-merge (squash) October 24, 2024 06:24
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 24, 2024 •
edited
Loading

Deploying kcmsx with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4af8134
Status: ✅  Deploy successful!
Preview URL: https://d8c357c9.kcmsx.pages.dev
Branch Preview URL: https://feat-555-main-ranking.kcmsx.pages.dev

View logs

@tufusa tufusa requested a review from laminne October 24, 2024 06:43
@tufusa tufusa merged commit 133c61d into main Oct 24, 2024
4 checks passed
@tufusa tufusa deleted the feat/555-main-ranking branch October 24, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laminne laminne laminne approved these changes

@speak-mentaiko speak-mentaiko Awaiting requested review from speak-mentaiko

@kiharu3112 kiharu3112 Awaiting requested review from kiharu3112

@Suzune2741 Suzune2741 Awaiting requested review from Suzune2741

Assignees

@tufusa tufusa

Labels
backend Related to kcmsx/kcms 新機能 New feature or request
Projects
kcmsx
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: ランキングの取得(GET /contest/{matchType}/{departmentType}/ranking)での本戦試合の実装
2 participants
@tufusa @laminne