This repository has been archived by the owner on May 30, 2024. It is now read-only.
Support Consul response code: 429 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkzo
force-pushed
the
callback/permit_429
branch
from
e5d4af8 to
88ffec6
Compare
|
#22 will drop support v3.5,please fetch and merge new commit drop support v3.5 |
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
==========================================
- Coverage 94.45% 94.36% -0.10%
==========================================
Files 6 6
Lines 1840 1845 +5
==========================================
+ Hits 1738 1741 +3
- Misses 102 104 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Consul returns a 429 response code when: Some healthchecks are passing, at least one is warning (see https://www.consul.io/api-docs/agent/service). This PR updates the callback handler to support response code 429.
kkzo
force-pushed
the
callback/permit_429
branch
from
69c49d0 to
2b6fb25
Compare
|
please merge as soon as convenient. If you do any kind of cluster monitoring with this package, the 429 response is a very common case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consul returns a 429 response code when: Some healthchecks are passing, at
least one is warning (see https://www.consul.io/api-docs/agent/service).
This PR updates the callback handler to support response code 429.