-
Notifications
You must be signed in to change notification settings - Fork 0
Description
A collection of suggestions for fixes and improvements to the show workflow graph option
Suggestions
- Set
workflow.show_workflowconfig variable totrueby default across CPG-flow repos so that workflow graphs are generated by default - Add titles to the two graphs presented in the html for clarity
Bugfixes
Fixing the web URL presented to the user
When the web URL for the output HTML is formatted, the access level and dataset name need to be fed in properly:
URL_BASENAME = 'https://{access_level}-web.populationgenomics.org.au/{name}/'Currently (see code) this uses the access_level, which is incorrect for full / standard access level. The strings "full" and "standard" need to be changed to "main" to match the bucket name syntax ("test" is fine since access level and bucket name syntax are aligned here). It also uses the workflow.name attribute to populate the second part of the URL base, when it should use the workflow.dataset.name attribute. In the case of test datasets (e.g. "my-dataset-test", the "-test" string needs to be removed.)
i.e. the config
[workflow]
access_level = "test"
dataset = "my-dataset"
Should generate URLs like:
https://test-web.populationgenomics.org.au/my-dataset/.../my_file.html
Which corresponds to the blob at
gs://cpg-my-dataset-test-web/.../my_file.html
Similarly, if you are using access_level = "full", ithould generate URLs like:
https://main-web.populationgenomics.org.au/my-dataset/.../my_file.html
Which corresponds to the blob at
gs://cpg-my-dataset-main-web/.../my_file.html