Miscellaneous code clean-ups #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes will require six >= 1.12.0 because they make use of six.ensure_binary, six.ensure_str, and six.ensure_text, which were introduced in that version.
|
We already require six >= 1.13 in other projects, and agreed on that, so I guess it chould be the same here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the new code requires
six >= 1.12, but an older version is installed with some Python versions on Travis (Python 2.7 and 3.7).We could add
six >= 1.12to the Travis configuration, but shouldn'tsoma-workflowbe free of external dependencies, so that it works out of the box when installed on a server with the auto-install feature? On the other hand, the auto-install feature seems to be broken anyway (#56).I see two ways forward:
Really require
six >= 1.12, add it to the Travis config, and find a way to make the auto-install functional or deprecate it entirely;Get rid of the dependency of
sixby incorporatingsix.pyin the code. This is allowed by the licence, and actually we did it already for casa-distro.@populse/soma what is your preference betwee solution 1 / solution 2?