Skip to content

Commit

Permalink
Update to 100 builds fetched (#1109)
Browse files Browse the repository at this point in the history
# Description

**What** - Increase Jenkins builds fetch limit from 50 to 100 builds per
job

**Why** - From a customer request in this [slack support
thread](https://getport.slack.com/archives/C07TSF9TC48/p1730210539061229)

**How** - Modified the builds pagination parameter in the Jenkins API
query from {0,50} to {0,100}, which is the maximum number of builds that
Jenkins API allows per request.


## Type of change

Please leave one option from the following and delete the rest:

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] New Integration (non-breaking change which adds a new integration)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [x] Non-breaking change (fix of existing functionality that will not
change current behavior)
- [ ] Documentation (added/updated documentation)

<h4> All tests should be run against the port production
environment(using a testing org). </h4>

### Core testing checklist

- [x] Integration able to create all default resources from scratch
- [x] Resync finishes successfully
- [x] Resync able to create entities
- [x] Resync able to update entities
- [x] Resync able to detect and delete entities
- [x] Scheduled resync able to abort existing resync and start a new one
- [x] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector


### Integration testing checklist

- [x] Integration able to create all default resources from scratch
- [x] Resync able to create entities
- [x] Resync able to update entities
- [x] Resync able to detect and delete entities
- [x] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add
example raw data, mapping and expected result to the `examples` folder
in the integration directory.
- [ ] If resource kind is updated, run the integration with the example
data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that
live-events for that resource are working as expected
- [x] Docs PR link
[here](port-labs/port-docs#1689)

### Preflight checklist

- [ ] Handled rate limiting
- [ ] Handled pagination
- [ ] Implemented the code in async
- [ ] Support Multi account

## Screenshots

Include screenshots from your environment showing how the resources of
the integration will look.

## API Documentation

Provide links to the API documentation used for this integration.
  • Loading branch information
phalbert authored Oct 30, 2024
1 parent 01c7bad commit f0efd1e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
5 changes: 5 additions & 0 deletions integrations/jenkins/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

<!-- towncrier release notes start -->
## 0.1.67 (2024-10-30)

### Improvements

- Increase builds fetched per job from 50 to 100

## 0.1.66 (2024-10-23)

Expand Down
2 changes: 1 addition & 1 deletion integrations/jenkins/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ def _build_api_params(

jobs_pagination = f"{{{start_idx},{end_idx}}}"
builds_query = (
",builds[id,number,url,result,duration,timestamp,displayName,fullDisplayName,previousBuild[id,url]]{0,50}"
",builds[id,number,url,result,duration,timestamp,displayName,fullDisplayName,previousBuild[id,url]]{0,100}"
if resource == "builds"
else ""
)
Expand Down
2 changes: 1 addition & 1 deletion integrations/jenkins/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "jenkins"
version = "0.1.66"
version = "0.1.67"
description = "Jenkins Integration to Port Ocean"
authors = ["Albert Luganga <ahosea15@gmail.com>"]

Expand Down

0 comments on commit f0efd1e

Please sign in to comment.