Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Entity diff calculation only on resync #1360

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

yaelibarg
Copy link
Contributor

@yaelibarg yaelibarg commented Jan 29, 2025

Description

What - made the entity diff calculation only on resync

Why - most of the events that are not resync dont change alot of entities, so its not worth searching the entity and checking diff on it

How - added a check if event.event_type == EventType.RESYNC:

Type of change

Please leave one option from the following and delete the rest:

  • New feature (non-breaking change which adds functionality)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

…if we want to calcualte diff or just upsert all
@yaelibarg yaelibarg requested a review from a team as a code owner January 29, 2025 12:48
@github-actions github-actions bot added size/L and removed size/M labels Jan 29, 2025
@yaelibarg yaelibarg changed the title [Core] Entity diff calculation as optional feature [Core] Entity diff calculation only on resync Jan 29, 2025
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaelibarg yaelibarg merged commit bacb281 into main Jan 29, 2025
53 checks passed
@yaelibarg yaelibarg deleted the PORT-12748-ocean-entities-diff-calculation-load-on-dv branch January 29, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants