[Core] Port 11686 Reduce cases of mass deletion #1363
+100
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaelibarg
changed the title
…es-of-mass-deletion-from-integration-transfer-go
| @@ -78,6 +78,7 @@ async def delete_diff( | |||
| self, | |||
| entities: EntityDiff, | |||
| user_agent_type: UserAgentType, | |||
| entity_deletion_threshold: float = 0.9, | |||
There was a problem hiding this comment.
I think default here should be Null and the value will be passed
There was a problem hiding this comment.
I think it will be clearer to communicate it through precentage e.g. 90 rather than 0.9, wdyt?
Comment on lines
+93
to
94
| keeping_entities=len(kept_entities), | ||
| ) |
There was a problem hiding this comment.
Suggested change
| keeping_entities=len(kept_entities), | |
| ) | |
| keeping_entities=len(kept_entities), | |
| entity_deletion_threshold=entity_deletion_threshold | |
| ) |
| ) | ||
|
|
||
| await self._safe_delete(diff.deleted, kept_entities, user_agent_type) | ||
| delete_rate = len(diff.deleted) / len(entities["before"]) |
There was a problem hiding this comment.
lets use another parameter name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - Reduce cases of mass deletion from integrations (could be because of bad api's we use or just getting {} from port on the mapping)
Why - we dont want to loose data in port
How - intreduce flag
entityDeletionThresholdType of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist