-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): add store prop #214
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
this.change$.next({type: 'loading', isLoading: true}) | ||
|
||
this.schemaTypes = getPortableTextMemberSchemaTypes( | ||
props.schemaType.hasOwnProperty('jsonType') | ||
? props.schemaType | ||
: compileType(props.schemaType), | ||
) | ||
|
||
// If no store is provided then we just create one | ||
this.store = props.store ?? createEditorStore() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word store here is the only thing I can think could be discussed. I prefer the API – I just don't know about the terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've renamed it to editor
now.
It's been deprecated for years. Time to remove it now that `patches$` is getting deprecated as well.
The `store` is a new, experimental way of interacting with and listening to events from the editor. So far it's only used to send patches into the editor.
5d0007a
to
6518f10
Compare
The
store
is a new, experimental way of interacting with and listening toevents from the editor.
So far it's only used to send patches into the editor.