portacle-update: don't try to delete used packages #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the "package-delete: Package ‘async-20180527.1030’ is used by ‘with-editor’ as dependency, not deleting" error, which caused the update to not end cleanly.
|
I'm not sure if this is correct. It seems to me that we might not be deleting everything we can if we simply forfeit used packages, as they might be used by a pending deletion. Perhaps packages need to be deleted in dependency order to avoid triggering the error. |
|
Alright, getting it to work by ignoring any errors in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
portacle-update was triggering errors like
causing the update to be interrupted.
Fixed by checking if the package is used elsewhere before trying to delete it.