Create new project modal wizard radio buttons #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow key navigation is not yet implemented. Helpful resource: https://www.w3.org/WAI/ARIA/apg/patterns/radio/
These IDs can be referenced by other elements to set the aria attributes such as `aria-labelledby` and `aria-describedby`.
Remove `isFirstButtonInGroup` from RadioButton because the tabIndex should be set on the currently selected button, not necessarily the first button in the group. If we support radio button groups without a default selection, then we may want to add similar logic back in, to set the tabIndex on the first button in the group if no button is selected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Defines
RadioButtonandRadioGroupto be used in modal dialog components. The RadioButton circle is custom, leveraging theme colours instead of the default radio button look.Preview of radio buttons in different themes
Interaction preview (clicking and keyboard nav)
new_project_radio_buttons.mp4
Approach
RadioButtonandRadioGroupRadioButtonItem[]is passed to theRadioGroupfor displayRadioGrouptabIndex: 0. Other non-selected items havetabIndex: -1wizardStepandwizardSubSteptosrc/vs/workbench/browser/positronNewProjectWizard/componentsinstead of in the broaderpositronModalDialogdirectory)QA Notes
This change is still part of scaffolding the feature and does not have corresponding test cases at the moment!