Add R Configuration step UI to Project Wizard #2766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creates the component for the R config step - directs the user to the R config step if the R Project type is selected
- use a single component for interpreter dropdown items, regardless of project type - share the interpreter dropdown entry filtering between R and Python
`setProjectConfig` was getting called, but the wizard accept callback read the project config from the wizard state before the render loop had a chance to update the project config. As a result, project interpreter and environment information was missing from the project config. Saving the data in the project config at the time that they're updated and within `useEffect` ensures that the project config is up to date when the wizard accept callback is called. Also: - added installIpykernel property to the project config (not currently used) - removed unused code in newProjectWizardStepContainer.tsx - made the retrieval of the selected interpreter into a general function for any languageId
petetronic
approved these changes
Apr 15, 2024
|
Nice! I tried out the branch and was able to create an "R" project, and just to check, git and renv checkboxes are known to be not yet functional? |
Yes, the checkboxes should be clickable to check/uncheck them, but currently the user selection doesn't result in actual functionality |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Adds the R Configuration step and fixes some issues with project config data not being persisted properly.
r_config_step.mp4
Approach
PythonInterpreterEntry-->InterpreterEntry, so it can be used for both Python and R interpreter dropdownsinterpreterDropDownUtils.ts, and language-specific utils can be used viapythonEnvironmentStepUtils.tsandrConfigurationStepUtils.tsuseRenv,instalIpykernel)NewProjectWizardStep.RConfigurationpythonEnvironmentStep.tsx(mostly non-functional changes)QA Notes
Selecting
R Projecton the project type step should result in step 3 being the R Configuration step. The R Configuration step should pre-select the user's preferred interpreter.