Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/project wizard step input validation feedback #2782

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

sharon-wang
Copy link
Member

Intent

Demo

proj_wiz_input_validation.mp4

Themes

proj_wiz_input_validation_themes.mp4

Approach

  • support pre-formatted text in substep feedback by making the WizardSubStep feedback property owner-draw (the parent component defines the feedback element instead of just passing a string)
  • show an error and prevent navigating to the next step when the project name is empty or only whitespace
  • show a warning but allow navigating to the next step if the project name is an existing directory

QA Notes

The project name input validation does not cover checking if the project name only contains valid symbols (i.e. it is possible to enter any symbols such as $, % and \ which can result in an incompatible directory name depending on the operating system). This sort of validation should be added at the component level, since we need to check valid file/directory text input in various places (project wizard, save plot modal, etc.) -- see #2781.

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharon-wang sharon-wang merged commit d35c733 into main Apr 16, 2024
1 check passed
@sharon-wang sharon-wang deleted the feature/project-wizard-step-feedback branch April 16, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants