Feature/project wizard step input validation feedback #2782
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Demo
proj_wiz_input_validation.mp4
Themes
proj_wiz_input_validation_themes.mp4
Approach
WizardSubStep
feedback
property owner-draw (the parent component defines thefeedback
element instead of just passing a string)QA Notes
The project name input validation does not cover checking if the project name only contains valid symbols (i.e. it is possible to enter any symbols such as
$
,%
and\
which can result in an incompatible directory name depending on the operating system). This sort of validation should be added at the component level, since we need to check valid file/directory text input in various places (project wizard, save plot modal, etc.) -- see #2781.