Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Wizard: use python extension environment providers #3082

Merged

Conversation

sharon-wang
Copy link
Member

Intent

Scaffolding for #2838 and #2839 to pull the list of available environment providers from the python extension, instead of the hardcoded list of Venv and Conda.

Currently, it looks like only Venv and Conda are supported via the python extension (at least via the Create Environment quickpick command).

Approach

  • register new command in python extension python.getCreateEnvironmentProviders
  • rename "envType" to "envProvider" in project wizard code to align better with the python extension (and to avoid confusion between "envType" and "envSetupType")
  • retrieve the list of python environment providers and store in the wizard state during project modal initialization

QA Notes

The Python Environment dropdown and related functionality should look exactly the same. The only difference is that the dropdown is filled with data from the python extension instead of hardcoded text.

- add new command to python extension `python.getCreateEnvironmentProviders`
- instead of the hardcoded list of Venv and Conda, retrieve the list of providers reported by the python extension via the new command
- populate the project wizard dropdown with the list of providers
- ensure the available interpreters are filtered by the selected provider
@sharon-wang sharon-wang requested review from seeM and timtmok May 9, 2024 17:49
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python extension changes LGTM!

@sharon-wang sharon-wang merged commit 7dc2280 into main May 10, 2024
24 checks passed
@sharon-wang sharon-wang deleted the feature/project-wizard-use-python-extension-env-providers branch May 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants