Fix "Python: Create Environment" not selecting the corresponding interpreter #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed venvs are now created and prompt to install ipykernel, and complete successfully when Install is selected. Tested this branch on both Mac and Windows. |
petetronic
approved these changes
May 30, 2024
jmcphers
approved these changes
May 30, 2024
src/vs/workbench/services/runtimeSession/common/runtimeSession.ts
Outdated
Show resolved
Hide resolved
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Address #3298.
Approach
The fix is to listen to
IInterpreterService.onDidChangeInterpreterand callselectLanguageRuntime.Unfortunately, that makes it possible to do quick consecutive calls to
selectLanguageRuntimewhich errors before this PR. The second change is to coalesceselectLanguageRuntime– indirectly, by extractingshutdownRuntimeSessionand coalescing calls to it. That'll also be needed when we bring functionality from positron-notebook-controller into positron core (#2671).QA Notes
See the repro in the issue, also worth playing around with the "Python: Select Interpreter" command, and the other ways of shutting down a runtime in the UI.