Move the hasRunningNotebookSession context out of the notebook session service
#5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion service; add tests
…ts` and remove stubbing; use a real notebook in notebook controller tests
nstrayer
approved these changes
Dec 11, 2024
| @@ -75,7 +75,7 @@ const extensions = [ | |||
| { | |||
| label: 'positron-notebook-controllers', | |||
| workspaceFolder: 'extensions/positron-notebook-controllers/test-workspace', | |||
| mocha: { timeout: 60_000 } | |||
| mocha: { timeout: 5_000 } | |||
There was a problem hiding this comment.
Yeah, it's actually helpful to have the tests fail when something hangs after 5 seconds. This extension's tests aren't in CI atm as well.
|
|
||
| export const log = vscode.window.createOutputChannel('Positron Notebook Controllers', { log: true }); | ||
|
|
||
| const _onDidSetHasRunningNotebookSessionContext = new vscode.EventEmitter<boolean>(); |
There was a problem hiding this comment.
Is this for testing purposes?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step toward removing the notebook session service entirely (#2671).
QA Notes
This shouldn't change any behavior, although I did fix some edge cases where the context was not set correctly.
Opening a notebook, restarting it, closing and reopening it should all work. The restart button should be deactivated when the session is exited.