Main thread runtime notebook kernels #5926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while already restarting from ready state
…otebooks listener
…uld drop the execution
This reverts commit 903b7a0.
|
E2E Tests 🚀 ? |
|
E2E test failure should be fixed by posit-dev/qa-example-content#42 |
jmcphers
previously approved these changes
Jan 10, 2025
| properties: { | ||
| [POSITRON_RUNTIME_NOTEBOOK_KERNEL_ENABLED_KEY]: { | ||
| type: 'boolean', | ||
| default: true, |
There was a problem hiding this comment.
If this is CAUTION Experimental, should it default to false for now?
There was a problem hiding this comment.
Ah, I ended up spending more time testing + hardening the PR than I initially intended on, so it turned out not to be CAUTION Experimental in the end. I've updated the description to reflect that in eb2315f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notebook kernels for language runtimes in the main thread. Before this, runtime kernels lived in the
positron-notebook-controllersextension. Having kernels in the main thread gives us more control over runtime session management. Addresses #2671.Should also address #4224 because of the way we manage notebook runtime sessions.
Some changes were required in the runtime session service in order to make this possible.
Release Notes
New Features
positron.runtimeNotebookKernel.enablesetting.Bug Fixes
QA Notes
I'll run E2E tests against this branch. Playing around with notebooks should also feel stable.
Should also address #4224.