chore: Add instructions and guidelines for porting features from bslib #2107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For humans and LLMs!
cpsievert
reviewed
Oct 28, 2025
scripts/README-porting-from-bslib.md
Outdated
|
|
||
| Key patterns: | ||
| - `Tag` objects are immutable by default, use `copy.copy()` if you need to modify | ||
| - Use `tagAppendAttributes()` to add classes/attributes |
There was a problem hiding this comment.
Should probably also add the __init__() based approach?
Suggested change
| - Use `tagAppendAttributes()` to add classes/attributes | |
| - Use `.add_class()`, `.add_style()`, `.attrs` to add CSS classes, styles, and HTML attributes |
There was a problem hiding this comment.
Could you say more about what you mean by the __init__() based approach? (I'm on board with the suggested change, but that seems unrelated unless I'm missing a step.)
There was a problem hiding this comment.
I mean something like it should prefer div(class_ = "foo") to x = div() then x.add_class("foo")
cpsievert
reviewed
Oct 28, 2025
cpsievert
reviewed
Oct 28, 2025
cpsievert
reviewed
Oct 28, 2025
cpsievert
reviewed
Oct 28, 2025
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For humans and LLMs!
I used the recent
input_submit_textarea()PRs to seed these guidelines:input_submit_textarea()input element rstudio/bslib#1204input_submit_textarea()andupdate_submit_textarea()#2099