raop: Fix broken audio streaming #2496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Audio streaming broke in the previous version due to nonce length changes. Apparently the encryption output counter was wrongly implemented as well (counter was always zero). Apple devices seems to be fine with that, but maybe some other devices doesn't like it? That is fixed now. Relates to #2479
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2496 +/- ##
==========================================
- Coverage 88.95% 88.84% -0.12%
==========================================
Files 168 168
Lines 11420 11421 +1
==========================================
- Hits 10159 10147 -12
- Misses 1261 1274 +13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Audio streaming broke in the previous version due to nonce length changes. Apparently the encryption output counter was wrongly implemented as well (counter was always zero). Apple devices seems to be fine with that, but maybe some other devices doesn't like it? That is fixed now.
Relates to #2479